Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP DNM: Joy/move attestation #20859

Closed
wants to merge 3 commits into from
Closed

WIP DNM: Joy/move attestation #20859

wants to merge 3 commits into from

Conversation

joyqvq
Copy link
Contributor

@joyqvq joyqvq commented Jan 10, 2025 •
edited
Loading

Description

included in https://github.com/MystenLabs/sui/blob/03aba9d6e5c17d04d5d8acefda80a5392c2091cb/sui-execution/v1/sui-move-natives/Cargo.toml for a different version of x509-parser (as opposed to 0.14 used by sui-types in sui-execution/latest) compiles ok.

x509-parser v0.13.2
└── sui-move-natives-v1 v0.1.0 (/Users/joy/mysten/sui/sui-execution/v1/sui-move-natives)
    ├── sui-adapter-v1 v0.1.0 (/Users/joy/mysten/sui/sui-execution/v1/sui-adapter)
    └── sui-execution v0.1.0 (/Users/joy/mysten/sui/sui-execution)
        [dev-dependencies]

Test plan

How did you test the new or updated feature?

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 10:17pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 10:17pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 10:17pm

@joyqvq joyqvq temporarily deployed to sui-typescript-aws-kms-test-env January 10, 2025 20:20 — with GitHub Actions Inactive
@joyqvq joyqvq changed the title Joy/move attestation WIP DNM: Joy/move attestation Jan 10, 2025
@joyqvq joyqvq force-pushed the joy/move-attestation branch from a39e06d to 6a4fe2e Compare January 10, 2025 20:45
@joyqvq joyqvq temporarily deployed to sui-typescript-aws-kms-test-env January 10, 2025 20:46 — with GitHub Actions Inactive
@joyqvq joyqvq force-pushed the joy/move-attestation branch from 6a4fe2e to 5f14b17 Compare January 10, 2025 20:49
@joyqvq joyqvq temporarily deployed to sui-typescript-aws-kms-test-env January 10, 2025 20:49 — with GitHub Actions Inactive
@joyqvq joyqvq force-pushed the joy/move-attestation branch from 5f14b17 to 8052c8d Compare January 10, 2025 22:16
@joyqvq joyqvq temporarily deployed to sui-typescript-aws-kms-test-env January 10, 2025 22:16 — with GitHub Actions Inactive
@joyqvq joyqvq force-pushed the joy/move-attestation branch from 8052c8d to e9237cb Compare January 11, 2025 03:49
@joyqvq joyqvq temporarily deployed to sui-typescript-aws-kms-test-env January 11, 2025 03:49 — with GitHub Actions Inactive
@joyqvq joyqvq force-pushed the joy/move-attestation branch from e9237cb to e9d8e0a Compare January 13, 2025 15:17
@joyqvq joyqvq temporarily deployed to sui-typescript-aws-kms-test-env January 13, 2025 15:17 — with GitHub Actions Inactive
@joyqvq joyqvq requested a review from benr-ml January 13, 2025 17:48
@joyqvq joyqvq force-pushed the joy/move-attestation branch from e9d8e0a to f4ba9cb Compare January 13, 2025 19:48
@joyqvq joyqvq temporarily deployed to sui-typescript-aws-kms-test-env January 13, 2025 19:48 — with GitHub Actions Inactive
@joyqvq joyqvq temporarily deployed to sui-typescript-aws-kms-test-env January 13, 2025 21:39 — with GitHub Actions Inactive
@joyqvq joyqvq changed the base branch from main to joy/attestation January 13, 2025 22:02
@joyqvq joyqvq changed the base branch from joy/attestation to main January 13, 2025 22:02
@joyqvq joyqvq force-pushed the joy/move-attestation branch from 9116522 to 55e7db4 Compare January 13, 2025 22:15
@joyqvq joyqvq temporarily deployed to sui-typescript-aws-kms-test-env January 13, 2025 22:15 — with GitHub Actions Inactive
@joyqvq joyqvq closed this Jan 13, 2025
@joyqvq joyqvq temporarily deployed to sui-typescript-aws-kms-test-env January 13, 2025 22:17 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benr-ml benr-ml Awaiting requested review from benr-ml

@ronny-mysten ronny-mysten Awaiting requested review from ronny-mysten ronny-mysten will be requested when the pull request is marked ready for review ronny-mysten is a code owner

@mystenmark mystenmark Awaiting requested review from mystenmark mystenmark will be requested when the pull request is marked ready for review mystenmark is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joyqvq